virtme-init: Enable lvm usage #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arighi
approved these changes
Oct 18, 2024
|
@marcosps now that I've merged the same change in virtme-ng-init, can you also update the submodule here in this PR, so the change will consistent? Thanks! |
Current /etc/lvm/ directories are restricted to root only (700), so just create an empty directory and bind mount over. This is enough to make commands like pvcreate to succeed. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
marcosps
force-pushed
the
enable-lvm-usage
branch
from
c4c8a5f to
1107900
Compare
|
@arighi done, thanks lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current /etc/lvm/ directories are restricted to root only (700), so just create an empty directory and bind mount over. This is enough to make commands like pvcreate to succeed.
It's the same commit as virtme-ng-init, but for virtme-init bash script. What do you think about this approach? Should we first check if the user is root before creating the bind mount?